Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor language menu and dom utils #32450

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Nov 8, 2024

  1. Make queryElem* functions could correctly handle TS types
  2. Remove some legacy jQuery $ calls (introduce fomanticQuery for Fomantic UI only)
  3. Fix some TS typing problems

Have manually tested: page language menu, image diff, dropdown tippy

TODO: in the future, all "queryElems(document, ...)" should be refactored to use a more specific parent.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 8, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 8, 2024
@github-actions github-actions bot added modifies/templates This PR modifies the template files modifies/frontend labels Nov 8, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 8, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 8, 2024
@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 8, 2024
@wxiaoguang wxiaoguang merged commit 0f397ae into go-gitea:main Nov 8, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Nov 8, 2024
@wxiaoguang wxiaoguang deleted the refactor-ts branch November 8, 2024 06:04
@wxiaoguang wxiaoguang modified the milestones: 1.24.0, 1.23.0 Nov 10, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 10, 2024
* giteaofficial/main:
  Refactor sidebar label selector (go-gitea#32460)
  Fix mermaid diagram height when initially hidden (go-gitea#32457)
  Add reviewers selection to new pull request (go-gitea#32403)
  Fix issue sidebar (go-gitea#32455)
  Refactor language menu and dom utils (go-gitea#32450)
  Fix broken releases when re-pushing tags (go-gitea#32435)
  Refactor issue page info (go-gitea#32445)
  Split issue sidebar into small templates (go-gitea#32444)
  Only provide the commit summary for Discord webhook push events (go-gitea#32432)
  Add new event commit status creation and webhook implementation (go-gitea#27151)
  Support quote selected comments to reply (go-gitea#32431)
  Move AddCollabrator and CreateRepositoryByExample to service layer (go-gitea#32419)

# Conflicts:
#	templates/repo/issue/view_content/context_menu.tmpl
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 6, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/templates This PR modifies the template files size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants