Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move some functions from issue.go to standalone files #32468

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 10, 2024

Just functions move, no code change.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 10, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 10, 2024
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 10, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Nov 10, 2024
@wxiaoguang wxiaoguang force-pushed the lunny/split_router_issue branch from fab14d2 to 574704b Compare November 10, 2024 22:47
@wxiaoguang
Copy link
Contributor

I was also doing so, so do more 574704b

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 10, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 11, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 11, 2024
@lunny lunny enabled auto-merge (squash) November 11, 2024 03:58
@lunny lunny merged commit a1892cf into go-gitea:main Nov 11, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Nov 11, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 11, 2024
@wxiaoguang wxiaoguang deleted the lunny/split_router_issue branch November 12, 2024 03:44
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 13, 2024
* giteaofficial/main:
  Disable Oauth check if oauth disabled (go-gitea#32368)
  Update JS and PY dependencies (go-gitea#32482)
  Update `github.com/meilisearch/meilisearch-go` (go-gitea#32484)
  Fix test fixtures for user2/lfs.git (go-gitea#32477)
  Limit org member view of restricted users (go-gitea#32211)
  cargo registry - respect renamed dependencies (go-gitea#32430)
  Refactor LFS SSH and internal routers (go-gitea#32473)
  Fix a number of typescript issues (go-gitea#32459)
  Harden runner updateTask and updateLog api (go-gitea#32462)
  Move some functions from issue.go to standalone files (go-gitea#32468)
@lunny lunny modified the milestones: 1.24.0, 1.23.0 Nov 13, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 9, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants