Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix LFS route mock, realm, middleware names #32488

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Fix LFS route mock, realm, middleware names #32488

merged 2 commits into from
Nov 13, 2024

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Nov 13, 2024 •
edited
Loading

  1. move "internal-lfs" route mock to "common-lfs"
  2. fine tune tests
  3. fix "realm" strings, according to RFC: https://datatracker.ietf.org/doc/html/rfc2617:
    • realm = "realm" "=" realm-value
    • realm-value = quoted-string
  4. clarify some names of the middlewares, rename ignXxx to optXxx to match reqXxx, and rename ambiguous requireSignIn to reqGitSignIn

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 13, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 13, 2024
@wxiaoguang wxiaoguang added this to the 1.23.0 milestone Nov 13, 2024
@wxiaoguang wxiaoguang added type/testing skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Nov 13, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Nov 13, 2024
@wxiaoguang wxiaoguang mentioned this pull request Nov 13, 2024
Merged
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 13, 2024
@wxiaoguang wxiaoguang changed the title Fix LFS route mock and realm Fix LFS route mock, realm, middleware names Nov 13, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 13, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 13, 2024
@wxiaoguang wxiaoguang merged commit 0aedb03 into go-gitea:main Nov 13, 2024
26 checks passed
@wxiaoguang wxiaoguang deleted the fix-lfs branch November 13, 2024 08:58
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 14, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
6332a5e 
* giteaofficial/main:
  Refactor render system (go-gitea#32492)
  Fix nil panic if repo doesn't exist (go-gitea#32501)
  Bump CI,Flake and Snap to Node 22 (go-gitea#32487)
  Perf: add extra index to notification table (go-gitea#32395)
  Fix LFS route mock, realm, middleware names (go-gitea#32488)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 11, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@lunny lunny lunny approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/dependencies modifies/go Pull requests that update Go code size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/testing
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @6543 @GiteaBot