Improve navbar: add "admin" tip, add "active" style #32927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
github-actions
bot
added
the
modifies/templates
This was referenced Dec 20, 2024
wxiaoguang
force-pushed
the
fix-navbar
branch
from
7716a76 to
499d417
Compare
|
I personally don't use a red color here. Maybe a primary color is enough? |
GiteaBot
added
lgtm/need 1
|
Changed to primary |
delvh
approved these changes
Dec 20, 2024
GiteaBot
added
lgtm/done
delvh
reviewed
Dec 20, 2024
lunny
added
the
reviewed/wait-merge
wxiaoguang
force-pushed
the
fix-navbar
branch
from
c344522 to
ada1903
Compare
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Dec 23, 2024
* giteaofficial/main: (62 commits) Fix repo avatar conflict (go-gitea#32958) [skip ci] Updated licenses and gitignores fix trailing comma not matched in the case of alphanumeric issue (go-gitea#32945) Add auto-expanding running actions step (go-gitea#30058) Fix go-gitea#32954 (go-gitea#32955) Use Alpine 3.21 for the docker images (go-gitea#32924) Refactor template & test related code (go-gitea#32938) Use primary as button color (go-gitea#32949) [skip ci] Updated translations via Crowdin Add action auto-scroll (go-gitea#30057) Fix locale (go-gitea#32937) Enable Typescript `strictFunctionTypes` (go-gitea#32911) Fix areYouSure confirm (go-gitea#32941) Update i18n.go - Language Picker (go-gitea#32933) Move some errors to their own sub packages (go-gitea#32880) Improve navbar: add "admin" tip, add "active" style (go-gitea#32927) Refactor db package and remove unnecessary `DumpTables` (go-gitea#32930) show warning on navigation if currently editing comment or title (go-gitea#32920) Refactor pprof labels and process desc (go-gitea#32909) [skip ci] Updated translations via Crowdin ...
|
@wxiaoguang Is there a reason this wasn't backported to v1.23 due to #32874 ? |
|
No particular reason, just because it looks trivial and this PR contains other fixes which are not easy to backport 😆 so feel free to backport |
-> Fix some UI problems for 1.23 #33856 |
wxiaoguang
added a commit
that referenced
this pull request
Mar 11, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By the way, remove all "tw-" patches and unused styles. Less code, better UI.