Inclusion of rename organization api

[bsofiato]

This adds an endpoint (/orgs/{org}/rename) to rename organizations.

I've modeled the endpoint using the rename user endpoint -- /admin/users/{username}/rename -- as base.

It is the 1st time I wrote a new API endpoint (I've tried to follow the rename users endpoint code while writing it). So feel free to ping me if there is something wrong or missing.

Resolves #32995

[yp05327]

You can reference the implementation here:

gitea/routers/api/v1/admin/user.go

Lines 475 to 502 in 7582eb0

	if ctx.ContextUser.IsOrganization() {
	ctx.Error(http.StatusUnprocessableEntity, "", fmt.Errorf("%s is an organization not a user", ctx.ContextUser.Name))
	return
	}
	oldName := ctx.ContextUser.Name
	newName := web.GetForm(ctx).(*api.RenameUserOption).NewName
	// Check if user name has been changed
	if err := user_service.RenameUser(ctx, ctx.ContextUser, newName); err != nil {
	switch {
	case user_model.IsErrUserAlreadyExist(err):
	ctx.Error(http.StatusUnprocessableEntity, "", ctx.Tr("form.username_been_taken"))
	case db.IsErrNameReserved(err):
	ctx.Error(http.StatusUnprocessableEntity, "", ctx.Tr("user.form.name_reserved", newName))
	case db.IsErrNamePatternNotAllowed(err):
	ctx.Error(http.StatusUnprocessableEntity, "", ctx.Tr("user.form.name_pattern_not_allowed", newName))
	case db.IsErrNameCharsNotAllowed(err):
	ctx.Error(http.StatusUnprocessableEntity, "", ctx.Tr("user.form.name_chars_not_allowed", newName))
	default:
	ctx.ServerError("ChangeUserName", err)
	}
	return
	}
	log.Trace("User name changed: %s -> %s", oldName, newName)
	ctx.Status(http.StatusNoContent)
	}

[lunny]

It's better to have a test.

[bsofiato]

It's better to have a test.

Hey @lunny, I've written a integration test to check for the new api :)

[wxiaoguang]

Made some changes:

1. use the same logic for RenameUser and RenameOrg
   • the known errors already provide good messages, so just use the "err" (then no ctx.Tr)
2. remove the log.Trace from handlers
   • the "trace" log is only used for debugging purpose, here we do not need that
3. remove all onGiteaRun from org tests
   • just use PrepareTestEnv, it's faster and simpler
4. make RenameOrg to be a sub-test
   • it is faster because no need to create a new org
5. by the way, found a buggy test case, added "FIXME" in code.
   • old code tests nothing .......

Diff with ignoring spaces: https://github.com/go-gitea/gitea/pull/33303/files?diff=unified&w=1