Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove "class-name" from svg icon #33540

Merged
merged 1 commit into from
Feb 9, 2025
Merged

Remove "class-name" from svg icon #33540

merged 1 commit into from
Feb 9, 2025

Conversation

wxiaoguang
Copy link
Contributor

Only use "class" attribute

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 9, 2025
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 9, 2025
@wxiaoguang wxiaoguang added type/refactoring Existing code has been cleaned up. There should be no new functionality. and removed modifies/frontend labels Feb 9, 2025
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Feb 9, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 9, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 9, 2025
@lafriks lafriks merged commit 06088ec into go-gitea:main Feb 9, 2025
26 checks passed
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 10, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
a32db18 
* giteaofficial/main:
  Feature: Support workflow event dispatch via API (go-gitea#32059)
  Remove "class-name" from svg icon (go-gitea#33540)
  Add "No data available" display when list is empty (go-gitea#33517)
  Add a option "--user-type bot" to admin user create, improve role display (go-gitea#27885)
@wxiaoguang wxiaoguang deleted the fix-svg-class branch February 10, 2025 03:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @lafriks @GiteaBot