Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move commits signature and verify functions to service layers #33605

Merged
merged 3 commits into from
Feb 16, 2025

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 15, 2025

No logic change, just move functions.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Feb 15, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 15, 2025
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 15, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Feb 15, 2025
@lunny lunny marked this pull request as ready for review February 16, 2025 05:19
@lunny lunny added this to the 1.24.0 milestone Feb 16, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 16, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 16, 2025
@yp05327
Copy link
Contributor

yp05327 commented Feb 16, 2025

Should the file names contain gpg_xxx in service level?

@lafriks lafriks enabled auto-merge (squash) February 16, 2025 11:59
@lafriks lafriks merged commit 58c124c into go-gitea:main Feb 16, 2025
26 checks passed
@lunny lunny deleted the lunny/move_commit_signature_func branch February 16, 2025 19:52
@lunny
Copy link
Member Author

lunny commented Feb 16, 2025

Should the file names contain gpg_xxx in service level?

Maybe a good idea but I kept it as before in this PR.

zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 17, 2025
* giteaofficial/main:
  Add API to support link package to repository and unlink it (go-gitea#33481)
  [skip ci] Updated translations via Crowdin
  Update JS and PY dependencies (go-gitea#33587)
  [chore] add git mailmap for proper attribution of authorship (go-gitea#33612)
  Move commits signature and verify functions to service layers (go-gitea#33605)
  add spacing between # button's icon and text (go-gitea#33609)
  enable literal string for code search (go-gitea#33590)
  [skip ci] Updated translations via Crowdin
  Artifacts download api for artifact actions v4 (go-gitea#33510)
  Fix bug when get commit (go-gitea#33602)
  Fix mirror bug (go-gitea#33597)
  Fix typo in HTML attribute (go-gitea#33599)
  Use default Git timeout when checking repo health (go-gitea#33593)
  Improve commits list performance to reduce unnecessary database queries (go-gitea#33528)
  Performance optimization for pull request files loading comments attachments (go-gitea#33585)
  Fix PR's target branch dropdown (go-gitea#33589)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants