-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Move UI configurations that do not require restarting gitea to take effect to the admin dashboard #33740
Conversation
hiifong
commented
Feb 27, 2025
•
edited
Loading
edited
It's better to split them as multiple sections. |
How does this work? Will it write into Regarding UI, I would make it so that all |
No, these configurations will be stored directly in the database in the future
Regarding UI issues, I will listen to your suggestions |
And which value takes precedence when database and app.ini conflict for a setting? |
It should be like other configurations which migrated from ini to database. Once migrated, the configuration item in the ini will be marked as deprecated and will not be read any more. |
As @lunny said, When upgrading gitea, the configuration in ini will be migrated to the database, and the migrated configuration items will be marked as deprecated in the ini configuration. The migrated configuration items are based on the configuration in the database. |
It does still seem like a bit of a sketchy mechanism because config can also come from env vars (in the docker case), and you can't "mark" stuff there. I recommend clearly mentioning this in the configuration docs, otherwise users might become confused why their env vars don't take effect. |
|
@lunny How about we save it for the next version? |
It seems that the ui section configuration does not support configuration from environment variables, But I'm not sure, can you tell me what configurations support getting them from environment variables? |
I found the answer in docs. Excuse me. |
299c00e
to
d675e9a
Compare