Skip to content

Fix some webhooks bugs #3981

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 10 commits into from
May 21, 2018
Merged

Fix some webhooks bugs #3981

merged 10 commits into from
May 21, 2018

Conversation

lunny
Copy link
Member

@lunny lunny commented May 17, 2018

No description provided.

@lunny lunny added the type/bug label May 17, 2018
@lunny lunny added this to the 1.5.0 milestone May 17, 2018
@lunny
Copy link
Member Author

lunny commented May 17, 2018 •
edited
Loading

block by go-gitea/go-sdk#107

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 17, 2018
@appleboy
Copy link
Member

@lunny update vendor. Done

@lunny
Copy link
Member Author

lunny commented May 18, 2018

@appleboy Thanks!

@codecov-io
Copy link

codecov-io commented May 18, 2018 •
edited
Loading

Codecov Report

Merging #3981 into master will decrease coverage by <.01%.
The diff coverage is 16.6%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3981      +/-   ##
==========================================
- Coverage   20.06%   20.05%   -0.01%     
==========================================
  Files         153      153              
  Lines       30122    30341     +219     
==========================================
+ Hits         6044     6086      +42     
- Misses      23168    23342     +174     
- Partials      910      913       +3
Impacted Files Coverage Δ
models/webhook_slack.go 0% <0%> (ø) ⬆️
models/webhook_dingtalk.go 0% <0%> (ø) ⬆️
models/issue_comment.go 27.22% <0%> (-0.32%) ⬇️
models/pull.go 17.17% <0%> (-0.1%) ⬇️
routers/repo/release.go 9.69% <0%> (ø) ⬆️
routers/api/v1/repo/release.go 0% <0%> (ø) ⬆️
models/webhook_discord.go 1.55% <0%> (-0.11%) ⬇️
models/repo.go 17.87% <0%> (-0.03%) ⬇️
models/release.go 0% <0%> (ø) ⬆️
models/issue_user.go 72.72% <100%> (+0.72%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc0ef38...b5a47a9. Read the comment docs.

@lunny
Copy link
Member Author

lunny commented May 18, 2018

fix #3579, #3492

@lunny
Copy link
Member Author

lunny commented May 18, 2018

fix #895

@lafriks
Copy link
Member

lafriks commented May 18, 2018

@lunny plaese fix fmt error

@lunny lunny force-pushed the lunny/fix_webhooks branch from dffe32c to c66d2a1 Compare May 18, 2018 14:20
@lunny
Copy link
Member Author

lunny commented May 18, 2018

@lafriks done.

@lunny lunny mentioned this pull request May 18, 2018
Closed
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 19, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 21, 2018
@lunny
Copy link
Member Author

lunny commented May 21, 2018

make L-G-T-M work

@lunny lunny merged commit 6bdc556 into go-gitea:master May 21, 2018
@lunny lunny deleted the lunny/fix_webhooks branch May 21, 2018 02:28
@lunny lunny mentioned this pull request May 21, 2018
Closed
@ghost ghost mentioned this pull request Jun 10, 2018
Closed
7 tasks
@lunny lunny mentioned this pull request Jun 10, 2018
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@appleboy appleboy appleboy approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @appleboy @codecov-io @lafriks @bkcsoft