Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Improve URL validation for external wiki and external issues (#4710) #4740

Merged
merged 1 commit into from
Aug 18, 2018
Merged

Improve URL validation for external wiki and external issues (#4710) #4740

merged 1 commit into from
Aug 18, 2018

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Aug 17, 2018

Backport #4710

@lafriks
Improve URL validation for external wiki and external issues (go-gite…
dae95a2 
…a#4710)

* Improve URL validation for external wiki  and external issues

* Do not allow also localhost address for external URLs
@lafriks lafriks added the topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! label Aug 17, 2018
@lafriks lafriks added this to the 1.5.1 milestone Aug 17, 2018
@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 17, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 17, 2018
@lunny
Copy link
Member

lunny commented Aug 17, 2018

LGTM

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 17, 2018
@techknowlogick techknowlogick merged commit 0665154 into go-gitea:release/v1.5 Aug 18, 2018
glitch003 pushed a commit to deconet/gitea that referenced this pull request Aug 21, 2018
@lafriks @glitch003
Improve URL validation for external wiki and external issues (go-gite…
a910e75 
…a#4710) (go-gitea#4740)

* Improve URL validation for external wiki  and external issues

* Do not allow also localhost address for external URLs
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@adelowo adelowo adelowo approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/security Something leaks user information or is otherwise vulnerable. Should be fixed!
Projects
None yet
Milestone
1.5.1
Development

Successfully merging this pull request may close these issues.
5 participants
@lafriks @lunny @techknowlogick @adelowo @bkcsoft