Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Backport: fix crippled diff (#4726) #4929

Merged
merged 4 commits into from
Sep 14, 2018

Conversation

tonivj5
Copy link
Contributor

@tonivj5 tonivj5 commented Sep 13, 2018

Backport of #4900

@SagePtr
Copy link
Contributor

SagePtr commented Sep 13, 2018

And make regenerate-stylesheet for this too (because it's quite different on different branches)

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 13, 2018
@tonivj5
Copy link
Contributor Author

tonivj5 commented Sep 13, 2018

@SagePtr, I commited with styles regenerated 😕 I have pushed an empty commit, but it's still failing

What can I do?

@techknowlogick
Copy link
Member

@xxxTonixxx it may be that you need to rm -rf node_modules and npm i it again before building. I know there was a change to the less library that caused a different output

@tonivj5
Copy link
Contributor Author

tonivj5 commented Sep 13, 2018

Thanks @techknowlogick, it was! 🎉

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 13, 2018
@lafriks lafriks added this to the 1.5.2 milestone Sep 14, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 14, 2018
@jonasfranz jonasfranz merged commit 177b46f into go-gitea:release/v1.5 Sep 14, 2018
@oscarlofwenhamn
Copy link
Contributor

@xxxTonixxx it may be that you need to rm -rf node_modules and npm i it again before building. I know there was a change to the less library that caused a different output

I am having a similar error,
Is this to be done in the gitea root folder or more so in the npm install folder?

@tonivj5
Copy link
Contributor Author

tonivj5 commented Nov 21, 2018

In the gitea root folder, @oscarlofwenhamn

@oscarlofwenhamn
Copy link
Contributor

Thanks!

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants