add commit file statuses #5607
Closed
add commit file statuses #5607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dependencies has been merged |
bkcsoft
added
the
lgtm/need 2
lunny
force-pushed
the
lunny/add_commit_file_status
branch
from
ff91fb6 to
2c2b00a
Compare
|
@lafriks updated |
lunny
force-pushed
the
lunny/add_commit_file_status
branch
from
2c2b00a to
74e919e
Compare
|
Looks like swagger needs updating |
lunny
force-pushed
the
lunny/add_commit_file_status
branch
from
74e919e to
4b28826
Compare
|
Do not add newline in the end of |
lunny
force-pushed
the
lunny/add_commit_file_status
branch
from
5201f89 to
f7c5a7a
Compare
|
@lafriks done. |
lunny
force-pushed
the
lunny/add_commit_file_status
branch
2 times, most recently
from
e0ec323 to
cdbb703
Compare
lunny
force-pushed
the
lunny/add_commit_file_status
branch
from
cdbb703 to
9ea8a32
Compare
lunny
force-pushed
the
lunny/add_commit_file_status
branch
from
9ea8a32 to
41ec892
Compare
|
Is there any work needed before it can get merged? |
| @@ -60,6 +60,8 @@ Values containing `#` or `;` must be quoted using `` ` `` or `"""`. | |||
| the top of the list. Name must match file name in conf/license or custom/conf/license. | |||
| - `DISABLE_HTTP_GIT`: **false**: Disable the ability to interact with repositories over the | |||
| HTTP protocol. | |||
| - `ACCESS_CONTROL_ALLOW_ORIGIN`: ****: Value for Access-Control-Allow-Origin header, default is not to present. | |||
There was a problem hiding this comment.
I think this is for a different PR?
There was a problem hiding this comment.
Suggested change
| - `ACCESS_CONTROL_ALLOW_ORIGIN`: ****: Value for Access-Control-Allow-Origin header, default is not to present. |
zeripath
reviewed
May 23, 2019
| @@ -60,6 +60,8 @@ Values containing `#` or `;` must be quoted using `` ` `` or `"""`. | |||
| the top of the list. Name must match file name in conf/license or custom/conf/license. | |||
| - `DISABLE_HTTP_GIT`: **false**: Disable the ability to interact with repositories over the | |||
| HTTP protocol. | |||
| - `ACCESS_CONTROL_ALLOW_ORIGIN`: ****: Value for Access-Control-Allow-Origin header, default is not to present. | |||
| WARNING: This maybe harmful to you website if you do not give it a right value. | |||
There was a problem hiding this comment.
Suggested change
| WARNING: This maybe harmful to you website if you do not give it a right value. |
zeripath
reviewed
May 23, 2019
| @@ -32,6 +32,8 @@ menu: | |||
| - `DEFAULT_PRIVATE`: 默认创建的git工程为私有。 可以是`last`, `private` 或 `public`。默认值是 `last`表示用户最后创建的Repo的选择。 | |||
| - `MAX_CREATION_LIMIT`: 全局最大每个用户创建的git工程数目， `-1` 表示没限制。 | |||
| - `PULL_REQUEST_QUEUE_LENGTH`: 小心：合并请求测试队列的长度，尽量放大。 | |||
| - `ACCESS_CONTROL_ALLOW_ORIGIN`: ****: Access-Control-Allow-Origin 头的值，默认为空。 | |||
There was a problem hiding this comment.
Suggested change
| - `ACCESS_CONTROL_ALLOW_ORIGIN`: ****: Access-Control-Allow-Origin 头的值，默认为空。 |
zeripath
reviewed
May 23, 2019
| @@ -32,6 +32,8 @@ menu: | |||
| - `DEFAULT_PRIVATE`: 默认创建的git工程为私有。 可以是`last`, `private` 或 `public`。默认值是 `last`表示用户最后创建的Repo的选择。 | |||
| - `MAX_CREATION_LIMIT`: 全局最大每个用户创建的git工程数目， `-1` 表示没限制。 | |||
| - `PULL_REQUEST_QUEUE_LENGTH`: 小心：合并请求测试队列的长度，尽量放大。 | |||
| - `ACCESS_CONTROL_ALLOW_ORIGIN`: ****: Access-Control-Allow-Origin 头的值，默认为空。 | |||
| 警告：如果您不熟悉这方面的设置请不要修改此值，可能影响网站安全。 | |||
There was a problem hiding this comment.
Suggested change
| 警告：如果您不熟悉这方面的设置请不要修改此值，可能影响网站安全。 |
lunny
force-pushed
the
lunny/add_commit_file_status
branch
from
a2a1324 to
bf4bcfb
Compare
Merged
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #4313 and
blocked by go-gitea/go-sdk#135 and go-gitea/git#137