Migration Tweaks #6260
Merged
Migration Tweaks #6260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds error checking before sanitization in migration Signed-off-by: jolheiser <john.olheiser@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #6260 +/- ##
=========================================
Coverage ? 41.57%
=========================================
Files ? 446
Lines ? 60848
Branches ? 0
=========================================
Hits ? 25296
Misses ? 32269
Partials ? 3283Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Signed-off-by: jolheiser <john.olheiser@gmail.com>
|
I think this is ready for review. Let me know if you'd prefer an alternate implementation. |
zeripath
approved these changes
May 20, 2019
GiteaBot
added
lgtm/need 1
|
conflicted |
Signed-off-by: jolheiser <john.olheiser@gmail.com>
sapk
approved these changes
May 24, 2019
GiteaBot
added
lgtm/done
lafriks
approved these changes
May 24, 2019
jeffliu27
pushed a commit
to jeffliu27/gitea
that referenced
this pull request
Jul 18, 2019
* Adds auto-name if repo name is blank Adds error checking before sanitization in migration Signed-off-by: jolheiser <john.olheiser@gmail.com> * Changed err from sanitization to a different variable Signed-off-by: jolheiser <john.olheiser@gmail.com> * Remove handleCreatePost and implement separately Signed-off-by: jolheiser <john.olheiser@gmail.com> * Make fmt Signed-off-by: jolheiser <john.olheiser@gmail.com>
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6253
Resolves #6254
6253
When migrating, the repo name will attempt to auto-name when the migrate/clone URL is entered. This will only happen if the repo name is empty so that it doesn't overwrite if the user enters something manually first.
6254
Unfortunately, as I described in the issue itself, the sanitization that happens makes the
IsErrxxxfunctions calculate incorrectly, so thehandleCreateErrorwas throwing 500s when it shouldn't have been.I don't particularly like that there is dupe code now, however, so I will likely try to clean that up before readying this PR for review.
Thoughts and suggestions are welcome.