Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add option to app.ini to enable local import paths #724

Merged
merged 1 commit into from
Jan 23, 2017
Merged

Add option to app.ini to enable local import paths #724

merged 1 commit into from
Jan 23, 2017

Conversation

Bwko
Copy link
Member

@Bwko Bwko commented Jan 22, 2017

Adds #715

@appleboy
Copy link
Member

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 23, 2017
@lunny lunny added this to the 1.1.0 milestone Jan 23, 2017
@lunny lunny added the type/enhancement An improvement of existing functionality label Jan 23, 2017
@lunny
Copy link
Member

lunny commented Jan 23, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 23, 2017
@lunny lunny merged commit 74ed6dc into go-gitea:master Jan 23, 2017
@tboerger
Copy link
Member

Why that? It's anyway only allowed to admins or people with the matching permission.

@Bwko
Copy link
Member Author

Bwko commented Jan 23, 2017

@tboerger Some people (like myself) want to disable this feature altogether. Even though this feature is only "allowed to admins or people with the matching permission". I don't want my admins to import local directories.

@tboerger
Copy link
Member

True, I have updated the label of the referenced issue, it's an enhancement but not something I would call a security issue

@Bwko
Copy link
Member Author

Bwko commented Jan 23, 2017

I agree, i'ts only a minor security issue.
When you give a user the right to import local paths he/she can import other peoples private repo's. Do we want to add additional checks to prevent this?

@Bwko Bwko deleted the local_imports branch January 23, 2017 10:24
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Bwko @appleboy @lunny @tboerger