Skip to content

Revert #7898 #8304

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 13 commits into from
Closed

Revert #7898 #8304

wants to merge 13 commits into from

Conversation

guillep2k
Copy link
Member

This PR reverts #7898 as it seems to produce more problems than it solves.

Fixes #8302
Fixes #8301 indirectly, by not using INSERT WHERE from xorm

@codecov-io
Copy link

Codecov Report

Merging #8304 into master will increase coverage by 0.01%.
The diff coverage is 51.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8304      +/-   ##
==========================================
+ Coverage   41.52%   41.53%   +0.01%     
==========================================
  Files         494      494              
  Lines       65384    65404      +20     
==========================================
+ Hits        27151    27166      +15     
- Misses      34737    34738       +1     
- Partials     3496     3500       +4
Impacted Files Coverage Δ
routers/api/v1/repo/pull.go 37.01% <33.33%> (-0.04%) ⬇️
routers/repo/pull.go 30.22% <33.33%> (+0.02%) ⬆️
models/issue.go 50.66% <60.86%> (-0.01%) ⬇️
models/repo_indexer.go 66.27% <0%> (-1.94%) ⬇️
models/gpg_key.go 56.66% <0%> (+0.83%) ⬆️
routers/repo/view.go 43.54% <0%> (+1.01%) ⬆️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️
models/unit.go 67.56% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6fb7fe...9a20c6a. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 27, 2019
@lunny lunny added the type/bug label Sep 28, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 28, 2019
@guillep2k
Copy link
Member Author

Reopens #7887

@guillep2k
Copy link
Member Author

I'm closing this because #8309 corrected #8301; I'll improve #8307 ASAP.

@guillep2k guillep2k closed this Sep 29, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. type/bug
Projects
None yet
4 participants