-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add HTML URL to API Issues #9654
Conversation
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #9654 +/- ##
==========================================
- Coverage 42.19% 42.16% -0.03%
==========================================
Files 583 583
Lines 77254 77360 +106
==========================================
+ Hits 32594 32618 +24
- Misses 40651 40728 +77
- Partials 4009 4014 +5
Continue to review full report at Codecov.
|
Looks like the refactor introduced a breaking change. If that was not intentional, I'd rather add |
This is also consistent with what github returns |
This is consistent with how |
No problem, I thought it could be a breaking change, that's all. |
This will also need a backport FYI. |
Will backport in a bit. |
* Add HTML URL to API Issues Signed-off-by: jolheiser <john.olheiser@gmail.com> * Swagger Signed-off-by: jolheiser <john.olheiser@gmail.com> Co-authored-by: Lauris BH <lauris@nix.lv>
After the recent refactor, webhooks are sending URLs pointing to the API rather than the instance.
This PR adds the HTML URL to API Issues. API PRs already have the HTML URL, so I assumed it was okay to add to Issues as well.