-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix add team on collaborator page when same name as organization #9767
Merged
sapk
merged 3 commits into
go-gitea:master
from
davidsvantesson:fix-add-teamname-same-as-organization
Jan 15, 2020
Merged
Fix add team on collaborator page when same name as organization #9767
sapk
merged 3 commits into
go-gitea:master
from
davidsvantesson:fix-add-teamname-same-as-organization
Jan 15, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
approved these changes
Jan 14, 2020
zeripath
approved these changes
Jan 14, 2020
should we backport this to 1.10.3 ? |
@6543 I think we should. |
Codecov Report
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 42.2% 42.16% -0.05%
==========================================
Files 602 603 +1
Lines 78669 78834 +165
==========================================
+ Hits 33206 33241 +35
- Misses 41399 41522 +123
- Partials 4064 4071 +7
Continue to review full report at Codecov.
|
@davidsvantesson can you send backport to 1.10.3? |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Labels
backport/done
All backports for this PR have been created
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9662
I think the intention of this code was to ignore if user tries to add "Owner" team to repository. The owner team is added to the repo anyhow and will be detected as a duplicate, so this check is not needed.