Optimize parse constraint #4153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adds support for named arguments in select * changes clause identifies and adds test
This was referenced Mar 9, 2021
mittwillson
pushed a commit
to itering/gorm
that referenced
this pull request
Sep 27, 2021
* for Config.cacheStore store PreparedStmtDB key * invalid db error and value and invalid value length error (go-gorm#4151) * support named params in Select API (go-gorm#4142) * adds support for named arguments in select * changes clause identifies and adds test * optimize match english letters and midline Co-authored-by: Ratan Phayade <ratanphayade@users.noreply.github.com>
cgxxv
pushed a commit
to cgxxv/gorm
that referenced
this pull request
Mar 25, 2022
* for Config.cacheStore store PreparedStmtDB key * invalid db error and value and invalid value length error (go-gorm#4151) * support named params in Select API (go-gorm#4142) * adds support for named arguments in select * changes clause identifies and adds test * optimize match english letters and midline Co-authored-by: Ratan Phayade <ratanphayade@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gorm/schema/relationship.go ParseConstraint method optimization.
The following code is basically called in for. In order to avoid the performance problems caused by repeated compilation of regular expressions, it only needs to be done once outside, so optimization is done here.