fix: automigrate error caused by indexes while using dynamic table name #4773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@longlihale I revised it again and now it's OK. The CI's error should be nothing to do with my revision, I have seen the same error in the master branch. |
ghost
requested review from
|
测试逻辑有些复杂看不出覆盖的场景，可以简单直接一些 |
huacnlee
reviewed
Oct 18, 2021
huacnlee
reviewed
Oct 18, 2021
|
已更新。 |
huacnlee
reviewed
Oct 19, 2021
| @@ -107,6 +116,9 @@ func Parse(dest interface{}, cacheStore *sync.Map, namer Namer) (*Schema, error) | |||
|
|
|||
| modelValue := reflect.New(modelType) | |||
| tableName := namer.TableName(modelType.Name()) | |||
| if schemaTable != "" { | |||
| tableName = schemaTable | |||
| } | |||
There was a problem hiding this comment.
反过来写
tableName = schemaTable
if schemaTable == "" {
tableName := namer.TableName(modelType.Name())
}
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
close #4752