#2 Refactor to use mappings

Signed-off-by: Davide Petilli <davide@petilli.me>
go-gremlins · Jun 25, 2022 · 1195b78 · 1195b78
1 parent 1a40e71
commit 1195b78
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 37 deletions.
diff --git a/mutator/types.go → mutator/mappings.go b/mutator/types.go → mutator/mappings.go
@@ -16,8 +16,26 @@
 
 package mutator
 
+import "go/token"
+
 type MutantType int
 
 const (
-	CONDITIONAL_BOUNDARY MutantType = iota
+	ConditionalBoundary MutantType = iota
 )
+
+func (mt MutantType) String() string {
+	switch mt {
+	case ConditionalBoundary:
+		return "Conditional Boundary"
+	default:
+		return ""
+	}
+}
+
+var tokenMutantType = map[token.Token]MutantType{
+	token.GTR: ConditionalBoundary,
+	token.LSS: ConditionalBoundary,
+	token.GEQ: ConditionalBoundary,
+	token.LEQ: ConditionalBoundary,
+}
diff --git a/mutator/mutator.go b/mutator/mutator.go
@@ -25,7 +25,7 @@ import (
 
 type Mutant struct {
 	MutantType MutantType
-	TokenType  token.Token
+	Token      token.Token
 	Position   token.Position
 	Covered    bool
 }
@@ -58,31 +58,13 @@ func (m Mutator) RunWithFileName(fileName string) []Mutant {
 }
 
 func inspectBinaryExpr(set *token.FileSet, be *ast.BinaryExpr) (Mutant, bool) {
-	switch be.Op {
-	case token.GTR:
-		return Mutant{
-			MutantType: CONDITIONAL_BOUNDARY,
-			TokenType:  token.GTR,
-			Position:   set.Position(be.OpPos),
-		}, true
-	case token.LSS:
-		return Mutant{
-			MutantType: CONDITIONAL_BOUNDARY,
-			TokenType:  token.LSS,
-			Position:   set.Position(be.OpPos),
-		}, true
-	case token.LEQ:
-		return Mutant{
-			MutantType: CONDITIONAL_BOUNDARY,
-			TokenType:  token.LEQ,
-			Position:   set.Position(be.OpPos),
-		}, true
-	case token.GEQ:
-		return Mutant{
-			MutantType: CONDITIONAL_BOUNDARY,
-			TokenType:  token.GEQ,
-			Position:   set.Position(be.OpPos),
-		}, true
+	mt, ok := tokenMutantType[be.Op]
+	if !ok {
+		return Mutant{}, false
 	}
-	return Mutant{}, false
+	return Mutant{
+		MutantType: mt,
+		Token:      be.Op,
+		Position:   set.Position(be.OpPos),
+	}, true
 }
diff --git a/mutator/mutator_test.go b/mutator/mutator_test.go
@@ -44,39 +44,39 @@ func TestMutations(t *testing.T) {
 		{
 			name:       "it recognizes CONDITIONAL_BOUNDARY with GTR",
 			fileName:   "testdata/fixtures/conditional_boundary_gtr_go",
-			mutantType: mutator.CONDITIONAL_BOUNDARY,
+			mutantType: mutator.ConditionalBoundary,
 			tokenType:  token.GTR,
 			covProfile: coveredPosition("testdata/fixtures/conditional_boundary_gtr_go"),
 			covered:    true,
 		},
 		{
 			name:       "it recognizes CONDITIONAL_BOUNDARY with LSS",
 			fileName:   "testdata/fixtures/conditional_boundary_lss_go",
-			mutantType: mutator.CONDITIONAL_BOUNDARY,
+			mutantType: mutator.ConditionalBoundary,
 			tokenType:  token.LSS,
 			covProfile: notCoveredPosition("testdata/fixtures/conditional_boundary_lss_go"),
 			covered:    false,
 		},
 		{
 			name:       "it recognizes CONDITIONAL_BOUNDARY with LEQ",
 			fileName:   "testdata/fixtures/conditional_boundary_leq_go",
-			mutantType: mutator.CONDITIONAL_BOUNDARY,
+			mutantType: mutator.ConditionalBoundary,
 			tokenType:  token.LEQ,
 			covProfile: notCoveredPosition("testdata/fixtures/conditional_boundary_leq_go"),
 			covered:    false,
 		},
 		{
 			name:       "it recognizes CONDITIONAL_BOUNDARY with GEQ",
 			fileName:   "testdata/fixtures/conditional_boundary_geq_go",
-			mutantType: mutator.CONDITIONAL_BOUNDARY,
+			mutantType: mutator.ConditionalBoundary,
 			tokenType:  token.GEQ,
 			covProfile: notCoveredPosition("testdata/fixtures/conditional_boundary_geq_go"),
 			covered:    false,
 		},
 		{
 			name:       "it skips illegal CONDITIONAL_BOUNDARY",
 			fileName:   "testdata/fixtures/conditional_boundary_illegal_go",
-			mutantType: mutator.CONDITIONAL_BOUNDARY,
+			mutantType: mutator.ConditionalBoundary,
 			tokenType:  token.ILLEGAL,
 			covProfile: notCoveredPosition("testdata/fixtures/conditional_boundary_illegal_go"),
 			covered:    false,
@@ -95,11 +95,11 @@ func TestMutations(t *testing.T) {
 				}
 				return
 			}
-			if !cmp.Equal(got[0].MutantType, mutator.CONDITIONAL_BOUNDARY) {
-				t.Errorf(cmp.Diff(got[0].MutantType, mutator.CONDITIONAL_BOUNDARY))
+			if !cmp.Equal(got[0].MutantType, mutator.ConditionalBoundary) {
+				t.Errorf(cmp.Diff(got[0].MutantType, mutator.ConditionalBoundary))
 			}
-			if !cmp.Equal(got[0].TokenType, tc.tokenType) {
-				t.Errorf(cmp.Diff(got[0].TokenType, tc.tokenType))
+			if !cmp.Equal(got[0].Token, tc.tokenType) {
+				t.Errorf(cmp.Diff(got[0].Token, tc.tokenType))
 			}
 			if !cmp.Equal(got[0].Covered, tc.covered) {
 				t.Errorf(cmp.Diff(got[0].Covered, tc.covered))