-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add invert logical operations mutator #146
Conversation
Codecov Report
@@ Coverage Diff @@
## main #146 +/- ##
==========================================
+ Coverage 87.54% 87.56% +0.01%
==========================================
Files 18 18
Lines 1293 1295 +2
==========================================
+ Hits 1132 1134 +2
Misses 134 134
Partials 27 27
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I disabled the dual linter, we have plenty of duplication checkers and that one seems to produce false positives. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello and thanks for the PR.
Could you please also update the documentation here:
gremlins/docs/docs/usage/configuration.md
Line 68 in 535bb9d
enabled: true |
And here https://github.com/go-gremlins/gremlins/blob/main/docs/docs/usage/commands/unleash/index.md
And also, wire the new page here:
Line 58 in 535bb9d
- usage/mutations/invert_negatives.md |
A new mutator replaces && with || and vice versa.
224c5d6
to
b8cbd7a
Compare
Update the commit. Rebased to main and added missed doc changes. |
I've just re-asked @k3rn31 for review and by some reason review request for @giorgiaroccetti was dropped automatically. I don't have access to get it back. |
Proposed changes
Closes #137
A new mutator replaces && with || and vice versa.
Types of changes
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.