Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add invert logical operations mutator #146

Merged
merged 1 commit into from
Aug 21, 2022

Conversation

vsvastey
Copy link
Contributor

Proposed changes

Closes #137
A new mutator replaces && with || and vice versa.

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@pull-request-size pull-request-size bot added the s/L Size: Denotes a Pull Request that changes 100-499 lines label Aug 20, 2022
@k3rn31 k3rn31 added the c/feature Category: An issue or PR related to a new feature label Aug 20, 2022
@k3rn31 k3rn31 self-assigned this Aug 20, 2022
@k3rn31 k3rn31 added this to the v0.4.0 milestone Aug 20, 2022
@k3rn31 k3rn31 changed the title Add invert logical operations mutator (#137) Add invert logical operations mutator Aug 20, 2022
@k3rn31 k3rn31 self-requested a review August 20, 2022 18:27
@codecov
Copy link

codecov bot commented Aug 20, 2022

Codecov Report

Merging #146 (224c5d6) into main (751a27a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 224c5d6 differs from pull request most recent head b8cbd7a. Consider uploading reports for the commit b8cbd7a to get more accurate results

@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
+ Coverage   87.54%   87.56%   +0.01%     
==========================================
  Files          18       18              
  Lines        1293     1295       +2     
==========================================
+ Hits         1132     1134       +2     
  Misses        134      134              
  Partials       27       27              
Flag Coverage Δ
unittests 87.56% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
configuration/mutantenabled.go 100.00% <ø> (ø)
pkg/mutant/mutant.go 87.50% <100.00%> (+0.83%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@k3rn31
Copy link
Member

k3rn31 commented Aug 20, 2022

I disabled the dual linter, we have plenty of duplication checkers and that one seems to produce false positives.

Copy link
Member

@k3rn31 k3rn31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello and thanks for the PR.

Could you please also update the documentation here:

And here https://github.com/go-gremlins/gremlins/blob/main/docs/docs/usage/commands/unleash/index.md

And also, wire the new page here:

- usage/mutations/invert_negatives.md

@k3rn31 k3rn31 requested a review from giorgiaroccetti August 20, 2022 18:45
A new mutator replaces && with || and vice versa.
@vsvastey vsvastey force-pushed the usr/vsvastey/invert_logical branch from 224c5d6 to b8cbd7a Compare August 20, 2022 19:35
@vsvastey
Copy link
Contributor Author

Update the commit. Rebased to main and added missed doc changes.

@vsvastey vsvastey requested review from k3rn31 and removed request for giorgiaroccetti August 20, 2022 19:45
@vsvastey
Copy link
Contributor Author

I've just re-asked @k3rn31 for review and by some reason review request for @giorgiaroccetti was dropped automatically. I don't have access to get it back.

@k3rn31 k3rn31 requested a review from giorgiaroccetti August 21, 2022 03:19
@k3rn31 k3rn31 merged commit 8f29247 into go-gremlins:main Aug 21, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
c/feature Category: An issue or PR related to a new feature s/L Size: Denotes a Pull Request that changes 100-499 lines
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Invert logical operators
2 participants