Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: process resources are not released #66

Merged

Conversation

k3rn31
Copy link
Member

@k3rn31 k3rn31 commented Jul 27, 2022

Fixed #65

@k3rn31 k3rn31 linked an issue Jul 27, 2022 that may be closed by this pull request
@pull-request-size pull-request-size bot added the s/S Size: Denotes a PR that changes 10-29 lines label Jul 27, 2022
@k3rn31 k3rn31 self-assigned this Jul 27, 2022
@k3rn31 k3rn31 added the c/bug Category: A issue or PR related to a bug label Jul 27, 2022
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #66 (ddcee98) into main (a19ff06) will decrease coverage by 0.26%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
- Coverage   86.65%   86.38%   -0.27%     
==========================================
  Files          10       10              
  Lines         562      573      +11     
==========================================
+ Hits          487      495       +8     
- Misses         59       61       +2     
- Partials       16       17       +1     
Flag Coverage Δ
unittests 86.38% <75.00%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/mutator/mutator.go 85.45% <75.00%> (-0.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a19ff06...ddcee98. Read the comment docs.

@k3rn31 k3rn31 merged commit 334a5d9 into main Jul 27, 2022
@k3rn31 k3rn31 deleted the 65-bug-sometimes-test-resources-are-not-released-properly branch July 27, 2022 10:34
k3rn31 added a commit that referenced this pull request Jul 27, 2022
@k3rn31 k3rn31 requested a review from giorgiaroccetti July 27, 2022 11:01
k3rn31 added a commit that referenced this pull request Jul 27, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
c/bug Category: A issue or PR related to a bug s/S Size: Denotes a PR that changes 10-29 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: sometimes test resources are not released properly
1 participant