Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Make Gremlins work on Windows #77

Merged
merged 2 commits into from
Jul 29, 2022
Merged

Make Gremlins work on Windows #77

merged 2 commits into from
Jul 29, 2022

Conversation

giose86
Copy link
Collaborator

@giose86 giose86 commented Jul 28, 2022 •
edited
Loading

Proposed changes

These fixes make gremlins works on Windows.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@giose86 giose86 requested a review from k3rn31 July 28, 2022 15:27
@giose86 giose86 linked an issue Jul 28, 2022 that may be closed by this pull request
Make Gremlins work on Windows #22
Closed
@k3rn31 k3rn31 requested a review from giorgiaroccetti July 28, 2022 15:28
@codecov
Copy link

codecov bot commented Jul 28, 2022 •
edited
Loading

Codecov Report

Merging #77 (1c32f58) into main (b7cc26a) will increase coverage by 0.76%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   86.77%   87.54%   +0.76%     
==========================================
  Files          11       11              
  Lines         590      602      +12     
==========================================
+ Hits          512      527      +15     
+ Misses         61       59       -2     
+ Partials       17       16       -1
Flag Coverage Δ
unittests 87.54% <100.00%> (+0.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/coverage/coverage.go 100.00% <100.00%> (ø)
pkg/mutator/mutator.go 87.71% <100.00%> (+2.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7cc26a...1c32f58. Read the comment docs.

@pull-request-size pull-request-size bot added the s/M Size: Denotes a Pull Request that changes 30-99 lines label Jul 28, 2022
@k3rn31 k3rn31 added the c/enhancement Category: An issue or PR related to sn enhancement label Jul 28, 2022
@k3rn31 k3rn31 self-assigned this Jul 28, 2022
k3rn31
k3rn31 reviewed Jul 28, 2022
View reviewed changes
cmd/unleash.go Outdated
@@ -45,6 +45,8 @@ func newUnleashCmd() *unleashCmd {
Long: `Unleashes the gremlins and performs mutation testing on a Go module.`,
RunE: func(cmd *cobra.Command, args []string) error {
log.Infoln("Starting...")
runDir, _ := os.Getwd()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it correct not to check the error here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hum...actually it would be better to check it, let me fix it :)

@giose86 giose86 force-pushed the 22-make-gremlins-work-on-windows branch from 60dbcd0 to d9ed8ca Compare July 28, 2022 21:03
@giose86 giose86 force-pushed the 22-make-gremlins-work-on-windows branch from d9ed8ca to 8a1f240 Compare July 29, 2022 07:04
@codeclimate
Copy link

codeclimate bot commented Jul 29, 2022

Code Climate has analyzed commit 1c32f58 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 89.7% (0.2% change).

View more on Code Climate.

@k3rn31 k3rn31 changed the title Fix gremlins test and execution errors (#22) Make Gremlins work on Windows Jul 29, 2022
@k3rn31 k3rn31 merged commit d2baf39 into main Jul 29, 2022
@k3rn31 k3rn31 deleted the 22-make-gremlins-work-on-windows branch July 29, 2022 12:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@k3rn31 k3rn31 k3rn31 approved these changes

@giorgiaroccetti giorgiaroccetti Awaiting requested review from giorgiaroccetti

Assignees

@k3rn31 k3rn31

Labels
c/enhancement Category: An issue or PR related to sn enhancement s/M Size: Denotes a Pull Request that changes 30-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Gremlins work on Windows
2 participants
@giose86 @k3rn31