Skip to content

__ne__ of set return NotImplemented #110

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Oct 8, 2019
Merged

Conversation

HyeockJinKim
Copy link
Contributor

if type of other is not set,
return NotImplemented

@HyeockJinKim HyeockJinKim changed the title __ne__ of sct return NotImplemented __ne__ of set return NotImplemented Sep 30, 2019
@codecov-io
Copy link

Codecov Report

Merging #110 into master will increase coverage by 0.19%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
+ Coverage   69.64%   69.84%   +0.19%     
==========================================
  Files          60       60              
  Lines       10810    10812       +2     
==========================================
+ Hits         7529     7552      +23     
+ Misses       2750     2726      -24     
- Partials      531      534       +3
Impacted Files Coverage Δ
py/set.go 75% <100%> (+16.81%) ⬆️
py/bool.go 34.04% <0%> (+6.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af17d7d...6aa008e. Read the comment docs.

@ncw ncw mentioned this pull request Oct 1, 2019
@ncw
Copy link
Collaborator

ncw commented Oct 8, 2019

Thank you :-) I'll merge this now.

@ncw ncw merged commit 1dceaf8 into go-python:master Oct 8, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants