Skip to content

Initial attempt at gometalinter rules #125

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Nov 7, 2019

Conversation

sbinet
Copy link
Member

@sbinet sbinet commented Nov 5, 2019

No description provided.

@sbinet
Copy link
Member Author

sbinet commented Nov 5, 2019

it seems f4ab05f was dropped from the main tree.
adding it back.

@sbinet sbinet requested review from corona10 and ncw November 5, 2019 14:43
@codecov-io
Copy link

Codecov Report

Merging #125 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #125   +/-   ##
=======================================
  Coverage   72.74%   72.74%           
=======================================
  Files          60       60           
  Lines       11970    11970           
=======================================
  Hits         8707     8707           
  Misses       2729     2729           
  Partials      534      534

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 051f189...d01e412. Read the comment docs.

Copy link
Collaborator

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@corona10 corona10 merged commit cbabf56 into go-python:master Nov 7, 2019
@sbinet sbinet deleted the gometalinter-rules branch November 7, 2019 08:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants