builtin: Implement builtin sum #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
==========================================
+ Coverage 64.5% 64.55% +0.05%
==========================================
Files 55 55
Lines 9740 9768 +28
==========================================
+ Hits 6283 6306 +23
- Misses 3010 3013 +3
- Partials 447 449 +2
Continue to review full report at Codecov.
|
|
@ncw PTAL |
sbinet
reviewed
Aug 31, 2018
corona10
force-pushed
the
builtin_sum
branch
from
16446fe to
ba56f58
Compare
|
@sbinet I've updated PTAL |
sbinet
approved these changes
Sep 1, 2018
|
@ncw Can you take a look? |
ncw
requested changes
Sep 3, 2018
builtin/tests/builtin.py
Outdated
| try: | ||
| sum(['h', 'i']) | ||
| except TypeError as e: | ||
| if e.args[0] != "unsupported operand type(s) for +: 'int' and 'string'": |
There was a problem hiding this comment.
This fails under python3 because the error message is actually
TypeError: unsupported operand type(s) for +: 'int' and 'str'
I'll work on getting py3test into the CI
corona10
force-pushed
the
builtin_sum
branch
from
ba56f58 to
8d3d3ff
Compare
corona10
force-pushed
the
builtin_sum
branch
from
8d3d3ff to
d5a6536
Compare
|
@ncw |
sbinet
approved these changes
Sep 4, 2018
ncw
approved these changes
Sep 4, 2018
|
Look great now - thanks :-) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement built-in sum.