Skip to content

Adding 'keys' and 'values' methods to dict object #213

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Jan 9, 2023

Conversation

kellrott
Copy link
Contributor

@kellrott kellrott commented Jan 5, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 74.33% // Head: 74.33% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (d6fdd01) compared to base (6f8e06a).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #213   +/-   ##
=======================================
  Coverage   74.33%   74.33%           
=======================================
  Files          76       76           
  Lines       12560    12576   +16     
=======================================
+ Hits         9336     9348   +12     
- Misses       2557     2559    +2     
- Partials      667      669    +2     
Impacted Files Coverage Δ
py/dict.go 78.07% <75.00%> (-0.51%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@sbinet sbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbinet sbinet merged commit 7512ac2 into go-python:main Jan 9, 2023
@kellrott kellrott deleted the feature/dict-keys branch January 10, 2023 21:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants