Adding __delitem__ to dict #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 74.35% // Head: 74.38% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
==========================================
+ Coverage 74.35% 74.38% +0.03%
==========================================
Files 76 76
Lines 12617 12625 +8
==========================================
+ Hits 9381 9391 +10
+ Misses 2563 2562 -1
+ Partials 673 672 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
sbinet
reviewed
Jan 13, 2023
py/dict.go
Outdated
Comment on lines
193
to
201
| str, ok := key.(String) | ||
| if ok { | ||
| _, ok := d[string(str)] | ||
| if ok { | ||
| delete(d, string(str)) | ||
| return None, nil | ||
| } | ||
| } | ||
| return nil, ExceptionNewf(KeyError, "%v", key) |
There was a problem hiding this comment.
Suggested change
| str, ok := key.(String) | |
| if ok { | |
| _, ok := d[string(str)] | |
| if ok { | |
| delete(d, string(str)) | |
| return None, nil | |
| } | |
| } | |
| return nil, ExceptionNewf(KeyError, "%v", key) | |
| str, ok := key.(String) | |
| if !ok { | |
| return nil, ExceptionNewf(KeyError, "%v", key) | |
| } | |
| _, ok = d[string(str)] | |
| if !ok { | |
| return nil, ExceptionNewf(KeyError, "%v", key) | |
| } | |
| delete(d, string(str)) | |
| return None, nil |
yes, it's longer, but only in the vertical dimension (however, it's less indented)
| del a["hello"] | ||
| assert not a.__contains__('hello') | ||
| assert a.__contains__('hi') | ||
|
|
There was a problem hiding this comment.
perhaps add a couple of cases that exercize the 2 ExceptionNewf branches ?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the 'del' command to delete items from a dict