-
Notifications
You must be signed in to change notification settings - Fork 97
py: Fix errors are suppressed in generator comprehensions #38
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
@ncw list(ax for x in range(10)) Can you recommend the proper place? |
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
==========================================
- Coverage 65.25% 65.24% -0.02%
==========================================
Files 56 56
Lines 10148 10150 +2
==========================================
Hits 6622 6622
- Misses 3064 3066 +2
Partials 462 462
Continue to review full report at Codecov.
|
@ncw PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you've found a good place for the test :-)
I put a few little changes inline.
The coverage of unit test does not relevant with this PR
I would have thought it would be pretty well covered.
Sequence.Iterate does not handle exceptions. Iterate() should return error except StopIteration.
@ncw |
That looks great thanks :-) I'll merge it now. It might be worth reveiwing other calls to |
Sequence.Iterate does not handle exceptions.
Iterate() should return error except StopIteration.
Fixes: #32