Skip to content

Add __new__ function and property of slice #99

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Sep 29, 2019

Conversation

HyeockJinKim
Copy link
Contributor

Issue #98

@codecov-io
Copy link

codecov-io commented Sep 29, 2019

Codecov Report

Merging #99 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
+ Coverage   69.09%   69.23%   +0.14%     
==========================================
  Files          60       60              
  Lines       10675    10692      +17     
==========================================
+ Hits         7376     7403      +27     
+ Misses       2781     2770      -11     
- Partials      518      519       +1
Impacted Files Coverage Δ
builtin/builtin.go 79.71% <100%> (+0.03%) ⬆️
py/slice.go 82% <100%> (+15.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c361a8...a604dc8. Read the comment docs.

@HyeockJinKim
Copy link
Contributor Author

@corona10
Can I get a review?

@corona10 corona10 requested review from ncw and corona10 September 29, 2019 07:48
Copy link
Collaborator

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corona10 corona10 merged commit 4b996c8 into go-python:master Sep 29, 2019
@HyeockJinKim HyeockJinKim deleted the issue98 branch September 29, 2019 12:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants