wrap mime.TypeByExtension with preset mimetypes #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, nicely done. Thanks ! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #182
Not quite sure if this is the best fix. But I looked at the files under
viewand they seem to be.css,.html,.js,.png. The corresponding mimetypes are preset in amap[string]stringvar.This seems to only happen on Windows, as the mimetypes are extracted from the registry as per Golang docs
If there's no preset mimetype, it calls
mime.TypeByExtensionunder the hood.If you believe there's a less obtrusive fix, please let me know!
Cheers!