-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: deleted time added to the database #903
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #903 +/- ##
==========================================
+ Coverage 25.58% 30.56% +4.97%
==========================================
Files 47 60 +13
Lines 5628 4486 -1142
==========================================
- Hits 1440 1371 -69
+ Misses 3989 2893 -1096
- Partials 199 222 +23 ☔ View full report in Codecov by Sentry. |
I'm still not sold on this because it changes a foundational thing about Shiori and it may be confusing for users (that delete no longer means delete). I'd rather think in a better way for third-parties to know when some bookmarks are gone. Is knowing when a bookmark has been deleted the only remaining problem? |
yes knowing deleted item is the remaining part.
client may don't have all bookmarks just have part of it. i need to return something like this:
one way is that i return any missing id with something like this (it is a quick code and has some bug) what do you think? WITH RECURSIVE range(id) AS (
SELECT 1
UNION ALL
SELECT id + 1 FROM range WHERE id < (SELECT MAX(id) FROM bookmark)
)
SELECT id
FROM range
WHERE id NOT IN (SELECT id FROM bookmark); |
This PR will record deleted time with bookmark id in a seprate table.
any specific unit test needed?
Why we need this?
for create a sync functionality we need to have 3 things
created_at
modifieded_at
anddeleted_at
the last one added in this PR. as
deleted_at
use case is just for sync than keep that in separate table make things cleaner.after merge #894 #896 and #903 i can finally send PR for add sync functionality to Shiori (some part of code is ready in local system). so user can sync their apps with Shiori server.