Upgrade superlo #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed external 'lo' package import from map.go and rewritten the Map function. Instead of reusing the Map function defined in 'lo' package, the iteration over the collection is now handled internally within Map itself. This change simplifies code, reduces third-party dependencies, and makes error handling more direct; function now immediate returns an error instead of panicking.
Added a new function, ParallelMap, to map.go to allow for parallel manipulation of a slice that transforms it to a different type. This was implemented to enhance performance by concurrently executing iterations, while maintaining the order of results. It also handles any possible errors which could occur during the execution.
Introduced test cases for the new ParallelMap function in map_test.go to ensure its correctness. Included both successful and erroneous scenarios to check for the proper handling of multiple conditions. This is necessary for validating the reliability and effectiveness of the ParallelMap logic under various circumstances.
chun37
approved these changes
Nov 27, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
panicのケアが大変なのでloの依存を無くしてしまった
欲しかったsuperlo.Mapの並列処理版を追加した