Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(api): add ref to dashboard build partial #1161

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Conversation

KellyMerrick
Copy link
Contributor

@KellyMerrick KellyMerrick commented Jul 17, 2024

Necessary so PR # can render in the UI for dashboard recent builds.

image

@KellyMerrick KellyMerrick self-assigned this Jul 17, 2024
@KellyMerrick KellyMerrick requested a review from a team as a code owner July 17, 2024 20:52
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.14%. Comparing base (75a9ee6) to head (e5266e2).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1161      +/-   ##
==========================================
- Coverage   52.14%   52.14%   -0.01%     
==========================================
  Files         550      550              
  Lines       18841    18842       +1     
==========================================
  Hits         9825     9825              
- Misses       8454     8455       +1     
  Partials      562      562              
Files Coverage Δ
api/types/dashboard.go 100.00% <ø> (ø)
mock/server/dashboard.go 0.00% <ø> (ø)
api/dashboard/get.go 0.00% <0.00%> (ø)

timhuynh94
timhuynh94 previously approved these changes Jul 17, 2024
@plyr4
Copy link
Contributor

plyr4 commented Jul 18, 2024

nice 👍

@plyr4
Copy link
Contributor

plyr4 commented Jul 18, 2024

@KellyMerrick KellyMerrick merged commit bde655a into main Jul 18, 2024
11 of 13 checks passed
@KellyMerrick KellyMerrick deleted the fix/dashboards branch July 18, 2024 19:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants