(Incremental) TD3: restart detected wpoints #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l restart due to read from old rho
Since wpoint restart changes `HM.find rho x` during `eq`, the following non-equality check should use the new value, not the old outdated one. The TD3 paper does the comparison using the non-cached value anyway.
|
We decided to start merging some of these together into the branch |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is currently built on top of #363 although technically it's independent of the incremental restarting logic from there.
I'm not sure if this would do anything useful for non-incremental solving though.
This is an attempt to further improve the incremental case, where a global gets restarted, but some local variables still contain the old value (due to global reads). It particularly concerns wpoints, where we don't overwrite and might join/widen the old value with the new one, thus republishing the old value again and having gained nothing from restarting the global.
This is achieved by doing the restart when
evaldetects awpointto ensure that the loop body (which may cause side effects) isn't ever re-evaluated with the old value.