FIX: Not crashing if cell doesnt exist while rendering attire

gobstones · Feb 8, 2017 · 3063f62 · 3063f62
1 parent 711306e
commit 3063f62
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 5 deletions.
diff --git a/dist/components/gs-cell.html b/dist/components/gs-cell.html
@@ -159,10 +159,13 @@
         }
       },
       _updateStyles: function(_arg, _arg1, rowIndex, cellIndex, boom) {
-        var attire, cell, table, url;
+        var attire, cell, table, url, _ref;
         table = _arg.base;
         attire = _arg1.base;
-        cell = table[rowIndex][cellIndex];
+        cell = (_ref = table[rowIndex]) != null ? _ref[cellIndex] : void 0;
+        if (cell == null) {
+          return;
+        }
         url = this.$.dresser.getImage(cell, attire);
         this.customStyle["--stones-visibility"] = (url != null) || boom ? "hidden" : "visible";
         if (url != null) {

diff --git a/dist/gs-board.html b/dist/gs-board.html
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "gs-board",
-  "version": "1.2.1",
+  "version": "1.2.2",
   "dependencies": {},
   "devDependencies": {
     "connect-livereload": "^0.4.0",

diff --git a/src/components/gs-cell/script.coffee b/src/components/gs-cell/script.coffee
@@ -49,7 +49,8 @@ Polymer
     throw new Error("The coordinates are required") if not @cellIndex? or not @rowIndex?
 
   _updateStyles: ({ base: table }, { base: attire }, rowIndex, cellIndex, boom) ->
-    cell = table[rowIndex][cellIndex]
+    cell = table[rowIndex]?[cellIndex]
+    return if not cell?
     url = @$.dresser.getImage cell, attire
 
     @customStyle["--stones-visibility"] = if url? or boom then "hidden" else "visible"