Fix encoding of string that contains "- " (#657)

* fix encoding of string that contains "- " * fix test case
goccy · Feb 15, 2025 · 89a6600 · 89a6600
1 parent 2ac8cff
commit 89a6600
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/encode_test.go b/encode_test.go
@@ -171,7 +171,7 @@ func TestEncoder(t *testing.T) {
 			},
 		},
 		{
-			"a: -\n",
+			"a: \"-\"\n",
 			map[string]string{"a": "-"},
 			nil,
 		},

diff --git a/token/token.go b/token/token.go
@@ -679,6 +679,9 @@ func IsNeedQuoted(value string) bool {
 	if isNumber(value) {
 		return true
 	}
+	if value == "-" {
+		return true
+	}
 	first := value[0]
 	switch first {
 	case '*', '&', '[', '{', '}', ']', ',', '!', '|', '>', '%', '\'', '"', '@', ' ', '`':
@@ -696,7 +699,7 @@ func IsNeedQuoted(value string) bool {
 		switch c {
 		case '#', '\\':
 			return true
-		case ':':
+		case ':', '-':
 			if i+1 < len(value) && value[i+1] == ' ' {
 				return true
 			}

diff --git a/token/token_test.go b/token/token_test.go
@@ -133,6 +133,8 @@ func TestIsNeedQuoted(t *testing.T) {
 		"Null",
 		"NULL",
 		"~",
+		"-",
+		"- --foo",
 	}
 	for i, test := range needQuotedTests {
 		if !token.IsNeedQuoted(test) {
-Original file line number
+Diff line change
@@ Expand Up / @@ -171,7 +171,7 @@ func TestEncoder(t *testing.T) { @@
     			},
     		},
     		{
-    			"a: -\n",
+    			"a: \"-\"\n",
     			map[string]string{"a": "-"},
     			nil,
     		},
@@ Expand Down @@