Fix bug that may prevent kwarg to be passed and add test #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The select_arguments wrapper was applied twice to the parent_picker and the combiner, resulting in any TypeError raised by either function accepting a kwarg resulted in the error being caught by the outer select_arguments wrapper and the kwarg not being passed anymore -- since the inner select_arguments wrapper does not have any specific kwargs.
Closed
|
I wonder, will this mix well with the idea that the parent picker might return an iterable? |
|
I don't see why not |
koaning
reviewed
Sep 26, 2018
tests/test_population.py
Outdated
| @@ -122,6 +122,18 @@ def test_breed_works_with_kwargs(self, simple_chromosomes, simple_evaluation_fun | |||
| assert len(pop2) == 400 | |||
| assert pop2.intended_size == 400 | |||
|
|
|||
| def test_breed_raises_with_multiple_values_for_kwarg(self, simple_population): | |||
|
|
|||
| def dummy_combiner(x, y): | |||
There was a problem hiding this comment.
That would work just a well. In this case I find any tracebacks easier to read but I guess that isn't really a problem here.
koaning
approved these changes
Sep 26, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The select_arguments wrapper was applied twice to the parent_picker
and the combiner, resulting in any TypeError raised by either function
accepting a kwarg resulted in the error being caught by the outer
select_arguments wrapper and the kwarg not being passed anymore -- since
the inner select_arguments wrapper does not have any specific kwargs.