Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

SCons: Implement minor fixes #102924

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Feb 16, 2025

Integrates a handful of adjustments to the SCons buildsystem:

  • Ensure scope of Configure is properly closed. This is "handled" automatically by SCons, but it recommends this practice & will prevent accidental breakage if wanting to further configure down the road.
  • Wrap post-build functions behind check for clean and help commands, so they only run when it's appropriate.
  • Use SCons 4.0+ implementation of dumping environment information
  • Ensure initial warning for lack of progress percentage is shown
  • Ensure elapsed time centiseconds won't crop leading zeros

@Repiteo Repiteo added this to the 4.x milestone Feb 16, 2025
@Repiteo Repiteo requested a review from a team as a code owner February 16, 2025 18:38
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

@Repiteo Repiteo modified the milestones: 4.x, 4.5 Feb 18, 2025
@Repiteo Repiteo force-pushed the scons/minor-fixes branch from bde5e6e to 2949ab0 Compare March 1, 2025 14:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants