Fix invalid startup embedded game location and size after resizing editor main area #103436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
approved these changes
Mar 1, 2025
Logharaa
reviewed
Mar 2, 2025
Hilderin
force-pushed
the
fix-invalid-embedded-game-location-size
branch
from
44b39ad to
0c9cacc
Compare
AThousandShips
approved these changes
Mar 2, 2025
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix simply uses the manual calculation for the location and size of the game not only on the first start (when the embedded control was invalid) but for every game start when floating window is disabled.
godot.windows.editor.dev.x86_64_uJmmgQAH6U.mp4