Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

C#: Fix missing CowData 64-bit promotion for PackedInt32Array. #88268

Merged
merged 1 commit into from
Feb 13, 2024
Merged

C#: Fix missing CowData 64-bit promotion for PackedInt32Array. #88268

merged 1 commit into from
Feb 13, 2024

Conversation

zaevi
Copy link
Contributor

@zaevi zaevi commented Feb 13, 2024

Fixes the missing Size promotion for PackedInt32Array after #86730

@zaevi zaevi requested a review from a team as a code owner February 13, 2024 04:26
@raulsntos raulsntos added this to the 4.3 milestone Feb 13, 2024
raulsntos
raulsntos approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thank you so much!

@akien-mga akien-mga merged commit fb688b3 into godotengine:master Feb 13, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@zaevi zaevi deleted the dotnet/fix_64bit_promotion branch February 13, 2024 10:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@raulsntos raulsntos raulsntos approved these changes

Assignees
No one assigned
Labels
bug regression topic:dotnet
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Exported array variable (PackedInt32Array) in C# resets to default value when game is run
3 participants
@zaevi @akien-mga @raulsntos