Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add stretchr/testify & update min version to go1.19 #933

Merged
merged 18 commits into from
Aug 23, 2023
Merged

Conversation

gaby
Copy link
Member

@gaby gaby commented Aug 20, 2023

  • Use https://github.com/stretchr/testify in place of utils.AssertEqual() for all storage drivers
  • Update Redis Cluster GitHub Action
  • Cleanup all go.mod files
  • Update min version of all drivers to go1.19
  • Added go1.21 to all test files
  • Migrate all usage of gofiber/utils to v2

@gaby
Copy link
Member Author

gaby commented Aug 20, 2023

Should the major version of the drivers that no longer support go1.17 and go1.18 be bump?

@gaby gaby added 🤖 Dependencies Pull requests that update a dependency file ❗ BreakingChange and removed 🤖 Dependencies Pull requests that update a dependency file labels Aug 20, 2023
Copy link
Member

@ReneWerner87 ReneWerner87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost perfect, just one little adjustment needed

azureblob/azureblob_test.go Outdated Show resolved Hide resolved
@gaby
Copy link
Member Author

gaby commented Aug 20, 2023

Should the major version of the drivers that no longer support go1.17 and go1.18 be bump?

^Only thing still TODO, is this.

@ReneWerner87
Copy link
Member

Should the major version of the drivers that no longer support go1.17 and go1.18 be bump?

^Only thing still TODO, is this.

yes lets do this

@gaby
Copy link
Member Author

gaby commented Aug 23, 2023

Should the major version of the drivers that no longer support go1.17 and go1.18 be bump?

^Only thing still TODO, is this.

yes lets do this

Done, most of the drivers are now v2 except for like 2-3 that are now v3. I also updated all the README files.

@gaby gaby requested a review from efectn August 23, 2023 04:33
@gaby gaby requested a review from ReneWerner87 August 23, 2023 04:33
# Conflicts:
#	azureblob/go.mod
#	azureblob/go.sum
#	dynamodb/go.mod
#	s3/go.mod
#	s3/go.sum
@ReneWerner87 ReneWerner87 merged commit 4248a8d into main Aug 23, 2023
69 checks passed
@gaby gaby deleted the testify branch August 23, 2023 10:49
@ReneWerner87 ReneWerner87 changed the title Add support for using stretchr/testify during tests Add stretchr/testify & update min version to go1.19 Aug 27, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants