Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove ineffectual assignment #8

Merged
merged 5 commits into from
May 9, 2020
Merged

Remove ineffectual assignment #8

merged 5 commits into from
May 9, 2020

Conversation

abahmed
Copy link
Member

@abahmed abahmed commented May 9, 2020 •
edited
Loading

Fixes #7

Changes proposed in this pull request:

  • Add start method tests
  • Fix ineffectual assignment and add tests
  • Limit actions to master push and PRs

@abahmed abahmed added the enhancement New feature or request label May 9, 2020
@abahmed abahmed merged commit f7a3893 into master May 9, 2020
@abahmed abahmed self-assigned this May 9, 2020
@abahmed abahmed deleted the remove-ineffectual-assignment branch May 10, 2020 02:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@abahmed abahmed

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove ineffectual assignment (goreportcard)
1 participant
@abahmed