Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

enhance: change tracing span name from request uri to router uri for http request #3338

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

seth-shi
Copy link
Contributor

update span name as route name, group route better than group request url

@seth-shi
Copy link
Contributor Author

url name:
11198d24d94d945b2810782ba66d436f

route name:
533817211a10fe6d63a0603447e6e891

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


url name:
11198d24d94d945b2810782ba66d436f

route name:
533817211a10fe6d63a0603447e6e891

@gqcn
Copy link
Member

gqcn commented Mar 4, 2024

@houseme @hailaz What do you guys think about this?

@gqcn gqcn requested review from houseme, gqcn and hailaz March 4, 2024 12:41
@gqcn gqcn changed the title Feature/tracing uri enhance: change tracing span name from request uri to router uri for http request Mar 4, 2024
@houseme
Copy link
Member

houseme commented Mar 4, 2024

可以汇总到一起

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


can be summarized together

@mingzaily
Copy link
Member

有意思的pr

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Interesting PR

@gqcn gqcn merged commit df15d70 into gogf:master Mar 5, 2024
20 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants