Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(os/gproc): missing arguments on Windows platform #3482

Merged
merged 6 commits into from
Apr 15, 2024

Conversation

wln32
Copy link
Member

@wln32 wln32 commented Apr 12, 2024

修复了在windows平台上设置 command.Args 参数失效的问题
例如以下代码,实际执行的命令是gf.exe ,不会有version参数

var command = gproc.NewProcess(“gf.exe”, nil)
command.Args = append(command.Args, "version")

本次提交内容如下:
1.在windows平台上修改为 当调用(*Process).Start方法时在设置执行命令的参数,其他平台行为不变

2.添加了一些在windows平台的测试

@wln32 wln32 requested review from gqcn, hailaz and oldme-git April 12, 2024 07:42
@wln32 wln32 linked an issue Apr 12, 2024 that may be closed by this pull request
@wln32 wln32 marked this pull request as draft April 12, 2024 14:39
@wln32 wln32 marked this pull request as ready for review April 13, 2024 02:56
@gqcn gqcn changed the title Fix setting Command on Windows platform. ARGS fix: missing arguments on Windows platform for package gproc Apr 15, 2024
@gqcn gqcn merged commit ae58dc8 into gogf:master Apr 15, 2024
23 checks passed
@wln32 wln32 deleted the fix/gproc-commoand-args branch April 15, 2024 03:18
@gqcn gqcn changed the title fix: missing arguments on Windows platform for package gproc fix(os/gproc): missing arguments on Windows platform Jun 27, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Serious] gproc command fail.
2 participants