refresh cache and insert repo to DB should be in one goroutine

goharbor · Sep 28, 2016 · f22f102 · f22f102
1 parent 7219544
commit f22f102
Showing 1 changed file with 4 additions and 13 deletions.
diff --git a/service/notification.go b/service/notification.go
@@ -71,12 +71,6 @@ func (n *NotificationHandler) Post() {
 			}
 		}()
 		if action == "push" {
-			go func() {
-				if err := cache.RefreshCatalogCache(); err != nil {
-					log.Errorf("failed to refresh cache: %v", err)
-				}
-			}()
-
 			go func() {
 				exist := dao.RepositoryExists(repository)
 				if exist {
@@ -87,14 +81,11 @@ func (n *NotificationHandler) Post() {
 				if err := dao.AddRepository(repoRecord); err != nil {
 					log.Errorf("Error happens when adding repository: %v", err)
 				}
+				if err := cache.RefreshCatalogCache(); err != nil {
+					log.Errorf("failed to refresh cache: %v", err)
+				}
 			}()
-
-			operation := ""
-			if action == "push" {
-				operation = models.RepOpTransfer
-			}
-
-			go api.TriggerReplicationByRepository(repository, []string{tag}, operation)
+			go api.TriggerReplicationByRepository(repository, []string{tag}, models.RepOpTransfer)
 		}
 		if action == "pull" {
 			go func() {