Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[cherry-pick]allow redis password safe special characters on release-2.8.0 #18587

Merged
merged 1 commit into from
Apr 24, 2023
Merged

[cherry-pick]allow redis password safe special characters on release-2.8.0 #18587

merged 1 commit into from
Apr 24, 2023

Conversation

MinerYang
Copy link
Contributor

@MinerYang MinerYang commented Apr 23, 2023

Signed-off-by: yminer yminer@vmware.com

string and None type conversion

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #18538

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: yminer <yminer@vmware.com>

string and None type conversion
@MinerYang MinerYang added the release-note/update Update or Fix label Apr 23, 2023
@MinerYang MinerYang requested a review from a team as a code owner April 23, 2023 13:03
@MinerYang MinerYang changed the title allow redis password safe special characters on release-2.8.0 [cherry-pick]allow redis password safe special characters on release-2.8.0 Apr 23, 2023
@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Merging #18587 (34f0289) into release-2.8.0 (1247578) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.8.0   #18587      +/-   ##
=================================================
+ Coverage          67.35%   67.37%   +0.02%     
=================================================
  Files                984      984              
  Lines             106987   106987              
  Branches            2670     2670              
=================================================
+ Hits               72059    72085      +26     
+ Misses             31049    31022      -27     
- Partials            3879     3880       +1     
Flag Coverage Δ
unittests 67.37% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants