Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

set tag pull time for proxy cache #18742

Merged

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented May 26, 2023

fixes #18708

to set the pull time of tag for the first time cache the artifact.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

fixes goharbor#18708

to set the pull time of tag for the first time cache the artifact.

Signed-off-by: Wang Yan <wangyan@vmware.com>
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #18742 (bae9362) into release-2.7.0 (7a0f0ea) will increase coverage by 22.46%.
The diff coverage is 30.00%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-2.7.0   #18742       +/-   ##
==================================================
+ Coverage          43.95%   66.41%   +22.46%     
==================================================
  Files                245     1012      +767     
  Lines              13396   108643    +95247     
  Branches            2677     2677               
==================================================
+ Hits                5888    72154    +66266     
- Misses              7222    32520    +25298     
- Partials             286     3969     +3683     
Flag Coverage Δ
unittests 66.41% <30.00%> (+22.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/controller/artifact/controller.go 63.13% <0.00%> (ø)
src/controller/proxy/controller.go 14.91% <0.00%> (ø)
src/controller/tag/controller.go 72.14% <66.66%> (ø)

... and 767 files with indirect coverage changes

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit ca8bbad into goharbor:release-2.7.0 May 29, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants