-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
exporter: add field alias for count(*) func #18840
Conversation
Codecov Report
@@ Coverage Diff @@
## main #18840 +/- ##
==========================================
- Coverage 67.38% 67.37% -0.02%
==========================================
Files 993 993
Lines 108894 108894
Branches 2751 2751
==========================================
- Hits 73381 73370 -11
- Misses 31566 31582 +16
+ Partials 3947 3942 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@liubin Hi, the output of the original and new SQL is same in my environment, you mentioned that the original SQL will always got 0 count, how did you reproduce that? ![]() |
aefea57
to
67f1790
Compare
@chlins Sorry I'm using oceanbase, it needs alias to let the beego orm to parse the filed name correctly. I updated the commit message and description of this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
67f1790
to
35f4caa
Compare
Add an alias so that orm can parse the column name regardless of the type and version of the database. Signed-off-by: bin liu <liubin0329@gmail.com>
35f4caa
to
970cf54
Compare
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Add an alias so that orm can parse the column name regardless of
the type and version of the database.
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: