-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
disable external redis using acl username auth #18893
disable external redis using acl username auth #18893
Conversation
Signed-off-by: yminer <yminer@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #18893 +/- ##
=======================================
Coverage 67.40% 67.40%
=======================================
Files 981 981
Lines 107194 107194
Branches 2698 2698
=======================================
+ Hits 72250 72256 +6
+ Misses 31059 31055 -4
+ Partials 3885 3883 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't merge
we don't need this, since could bypass this issue by follow this FAQ |
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Note: distribution configuration (until v2.8.2) only support auth by password
Issue being fixed
Fixes
Please indicate you've done the following: