Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

disable external redis using acl username auth #18893

Conversation

MinerYang
Copy link
Contributor

@MinerYang MinerYang commented Jul 5, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Note: distribution configuration (until v2.8.2) only support auth by password

Issue being fixed

Fixes

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: yminer <yminer@vmware.com>
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #18893 (8c46d98) into main (1efe944) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #18893   +/-   ##
=======================================
  Coverage   67.40%   67.40%           
=======================================
  Files         981      981           
  Lines      107194   107194           
  Branches     2698     2698           
=======================================
+ Hits        72250    72256    +6     
+ Misses      31059    31055    -4     
+ Partials     3885     3883    -2     
Flag Coverage Δ
unittests 67.40% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't merge

@MinerYang
Copy link
Contributor Author

we don't need this, since could bypass this issue by follow this FAQ

@MinerYang MinerYang closed this Jul 21, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants